Add new extensions to conformance csv files #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvh
reviewed
Sep 30, 2024
EwanC
force-pushed
the
ewan/extension_csv
branch
3 times, most recently
from
d4917b3
to
b03b1b8
Compare
EwanC
changed the title
svenvh
reviewed
Oct 1, 2024
There was a problem hiding this comment.
LGTM.
I've commented out cl_khr_external_semaphore in the CSVs, as creation of the binaries is conditional on the Vulkan SDK being enabled environment. I could alternatively put it in a separate CSV
No strong preference, but a separate file seems to be in line with what we do for D3D currently.
The extension tests in `test_conformance/extensions` have not matching entries in the `opencl_conformance_tests_full.csv` file. This means that they are missed from conformance runs by vendors who use this file.
EwanC
force-pushed
the
ewan/extension_csv
branch
from
b03b1b8
to
d0f27de
Compare
Thanks for the feedback, I asked on the 01/10/24 OpenCL teleconference and there was no objections to creating a new CSV. So i've updated this PR to add a new |
svenvh
approved these changes
Oct 2, 2024
|
Merging as discussed in the October 8th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension tests in
test_conformance/extensionshave not matching entries in theopencl_conformance_tests_*.csvfiles. This means that they are missed from conformance runs by vendors who use these files.I've included the new extensions in the full and quick CSV files as they don't have vast combinations of tests to run like bruteforce or conversions.
I've put
cl_khr_dx9_media_sharingin thetest_conformance/opencl_conformance_tests_d3d.csvCSV as like the other tests there the test binary is conditional built only on a Windows platform.I've created a new
opencl_conformance_tests_vulkan.csvfile for testing thecl_khr_external_semaphoreextension, as creation of the binary is conditional on the Vulkan SDK being enabled environment. Any other tests that require the Vulkan SDK in future can also be added there.